2 Commits e3ca5e636e ... 8f59e4a2af

Auteur SHA1 Message Date
  Dmitry Filimonchuk 8f59e4a2af Merge pull request #137 from dmitrystu/work/133-fix-pedantic il y a 2 ans
  Dmitry Filimonchuk d39665bad4 #133 fix possible pedantic errors il y a 2 ans

+ 1 - 1
src/usbd_stm32f103_devfs.c

@@ -345,7 +345,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static uint16_t pma_read (uint8_t *buf, uint16_t blen, pma_rec *rx) {
-    uint16_t tmp;
+    uint16_t tmp = 0;
     uint16_t *pma = PMA(rx->addr);
     uint16_t rxcnt = rx->cnt & 0x03FF;
     rx->cnt &= ~0x3FF;

+ 3 - 2
src/usbd_stm32f105_otgfs.c

@@ -321,7 +321,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static int32_t ep_read(uint8_t ep, void* buf, uint16_t blen) {
-    uint32_t len, tmp;
+    uint32_t len, tmp = 0;
     volatile uint32_t *fifo = EPFIFO(0);
     /* no data in RX FIFO */
     if (!(OTG->GINTSTS & USB_OTG_GINTSTS_RXFLVL)) return -1;
@@ -416,6 +416,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             case 0x03:  /* OUT completed */
             case 0x04:  /* SETUP completed */
                 _BST(EPOUT(ep)->DOEPCTL, USB_OTG_DOEPCTL_CNAK | USB_OTG_DOEPCTL_EPENA);
+                // fall through
             default:
                 /* pop GRXSTSP */
                 OTG->GRXSTSP;
@@ -436,7 +437,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             /* no more supported events */
             return;
         }
-        return callback(dev, evt, ep);
+        callback(dev, evt, ep);
     }
 }
 

+ 3 - 2
src/usbd_stm32f429_otgfs.c

@@ -318,7 +318,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static int32_t ep_read(uint8_t ep, void* buf, uint16_t blen) {
-    uint32_t len, tmp;
+    uint32_t len, tmp = 0;
     volatile uint32_t *fifo = EPFIFO(0);
     /* no data in RX FIFO */
     if (!(OTG->GINTSTS & USB_OTG_GINTSTS_RXFLVL)) return -1;
@@ -413,6 +413,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             case 0x03:  /* OUT completed */
             case 0x04:  /* SETUP completed */
                 _BST(EPOUT(ep)->DOEPCTL, USB_OTG_DOEPCTL_CNAK | USB_OTG_DOEPCTL_EPENA);
+                // fall through
             default:
                 /* pop GRXSTSP */
                 OTG->GRXSTSP;
@@ -433,7 +434,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             /* no more supported events */
             return;
         }
-        return callback(dev, evt, ep);
+        callback(dev, evt, ep);
     }
 }
 

+ 3 - 2
src/usbd_stm32f429_otghs.c

@@ -320,7 +320,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static int32_t ep_read(uint8_t ep, void* buf, uint16_t blen) {
-    uint32_t len, tmp;
+    uint32_t len, tmp = 0;
     volatile uint32_t *fifo = EPFIFO(0);
     /* no data in RX FIFO */
     if (!(OTG->GINTSTS & USB_OTG_GINTSTS_RXFLVL)) return -1;
@@ -418,6 +418,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             case 0x03:  /* OUT completed */
             case 0x04:  /* SETUP completed */
                 _BST(EPOUT(ep)->DOEPCTL, USB_OTG_DOEPCTL_CNAK | USB_OTG_DOEPCTL_EPENA);
+                // fall through
             default:
                 /* pop GRXSTSP */
                 OTG->GRXSTSP;
@@ -438,7 +439,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             /* no more supported events */
             return;
         }
-        return callback(dev, evt, ep);
+        callback(dev, evt, ep);
     }
 }
 

+ 2 - 2
src/usbd_stm32f446_otgfs.c

@@ -309,7 +309,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static int32_t ep_read(uint8_t ep, void* buf, uint16_t blen) {
-    uint32_t len, tmp;
+    uint32_t len, tmp = 0;
     ep &= 0x7F;
     volatile uint32_t *fifo = EPFIFO(0);
     USB_OTG_OUTEndpointTypeDef* epo = EPOUT(ep);
@@ -418,7 +418,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             /* no more supported events */
             return;
         }
-        return callback(dev, evt, ep);
+        callback(dev, evt, ep);
     }
 }
 

+ 2 - 2
src/usbd_stm32f446_otghs.c

@@ -309,7 +309,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static int32_t ep_read(uint8_t ep, void* buf, uint16_t blen) {
-    uint32_t len, tmp;
+    uint32_t len, tmp = 0;
     ep &= 0x7F;
     volatile uint32_t *fifo = EPFIFO(0);
     USB_OTG_OUTEndpointTypeDef* epo = EPOUT(ep);
@@ -418,7 +418,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             /* no more supported events */
             return;
         }
-        return callback(dev, evt, ep);
+        callback(dev, evt, ep);
     }
 }
 

+ 2 - 2
src/usbd_stm32h743_otgfs.c

@@ -309,7 +309,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static int32_t ep_read(uint8_t ep, void* buf, uint16_t blen) {
-    uint32_t len, tmp;
+    uint32_t len, tmp = 0;
     ep &= 0x7F;
     volatile uint32_t *fifo = EPFIFO(0);
     USB_OTG_OUTEndpointTypeDef* epo = EPOUT(ep);
@@ -418,7 +418,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             /* no more supported events */
             return;
         }
-        return callback(dev, evt, ep);
+        callback(dev, evt, ep);
     }
 }
 

+ 1 - 1
src/usbd_stm32l052_devfs.c

@@ -283,7 +283,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static uint16_t pma_read (uint8_t *buf, uint16_t blen, pma_rec *rx) {
-    uint16_t tmp;
+    uint16_t tmp = 0;
     uint16_t *pma = (void*)(USB_PMAADDR + rx->addr);
     uint16_t rxcnt = rx->cnt & 0x03FF;
     rx->cnt &= ~0x3FF;

+ 1 - 1
src/usbd_stm32l100_devfs.c

@@ -255,7 +255,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static uint16_t pma_read (uint8_t *buf, uint16_t blen, pma_rec *rx) {
-    uint16_t tmp;
+    uint16_t tmp = 0;
     uint16_t *pma = (void*)(USB_PMAADDR + 2 * rx->addr);
     uint16_t rxcnt = rx->cnt & 0x03FF;
     rx->cnt &= ~0x3FF;

+ 2 - 2
src/usbd_stm32l476_otgfs.c

@@ -342,7 +342,7 @@ static void ep_deconfig(uint8_t ep) {
 }
 
 static int32_t ep_read(uint8_t ep, void* buf, uint16_t blen) {
-    uint32_t len, tmp;
+    uint32_t len, tmp = 0;
     ep &= 0x7F;
     volatile uint32_t *fifo = EPFIFO(0);
     USB_OTG_OUTEndpointTypeDef* epo = EPOUT(ep);
@@ -451,7 +451,7 @@ static void evt_poll(usbd_device *dev, usbd_evt_callback callback) {
             /* no more supported events */
             return;
         }
-        return callback(dev, evt, ep);
+        callback(dev, evt, ep);
     }
 }